Artifact bd1a9cba051a8ffbbc33fbc5892a68071703f54e:

Manifest of check-in [bd1a9cba05] - Move `favicon` module into extension/feature plugin. Simplify row["favicon"] cache filename pregeneration; separate from favicon module (but basically duplicated code there). Refactor most internal favicon+banner processing, rename methods for clarity. Plugin registers itself as .hooks["play"] callback. Uses main.thread() now instead of custom variant. Create icon cache dir on initialiation rather. Use combined row_to_fn() for cache filename generation instead of domain(), url(), file(), etc. Previous banner downloads are ignored, because the filename normalization is more in line with domain favicons now. Only update pixstore on successful downloads. Pre-check the content type per binary regex now, before saving image files. Combine resizing into store_image() function as well. Even PNG files will be piped through PIL (for sanitization). Completely got rid of urllib usage. Homepage/HTML extraction got rewritten, simpler, still inexact; but works now for most webpages. Favicon homepage downloading checks both returned MIME type and actual file content prior saving. Shorten timeouts to 2-3 seconds for Google and custom favicon retrieval. by mario on 2015-05-10 19:20:49.

---

C Move\s`favicon`\smodule\sinto\sextension/feature\splugin.\nSimplify\srow["favicon"]\scache\sfilename\spregeneration;\sseparate\sfrom\sfavicon\nmodule\s(but\sbasically\sduplicated\scode\sthere).\nRefactor\smost\sinternal\sfavicon+banner\sprocessing,\srename\smethods\sfor\sclarity.\nPlugin\sregisters\sitself\sas\s.hooks["play"]\scallback.\nUses\smain.thread()\snow\sinstead\sof\scustom\svariant.\nCreate\sicon\scache\sdir\son\sinitialiation\srather.\nUse\scombined\srow_to_fn()\sfor\scache\sfilename\sgeneration\sinstead\sof\sdomain(),\nurl(),\sfile(),\setc.\nPrevious\sbanner\sdownloads\sare\signored,\sbecause\sthe\sfilename\snormalization\sis\nmore\sin\sline\swith\sdomain\sfavicons\snow.\nOnly\supdate\spixstore\son\ssuccessful\sdownloads.\nPre-check\sthe\scontent\stype\sper\sbinary\sregex\snow,\sbefore\ssaving\simage\sfiles.\nCombine\sresizing\sinto\sstore_image()\sfunction\sas\swell.\nEven\sPNG\sfiles\swill\sbe\spiped\sthrough\sPIL\s(for\ssanitization).\nCompletely\sgot\srid\sof\surllib\susage.\nHomepage/HTML\sextraction\sgot\srewritten,\ssimpler,\sstill\sinexact;\sbut\sworks\nnow\sfor\smost\swebpages.\sFavicon\shomepage\sdownloading\schecks\sboth\sreturned\nMIME\stype\sand\sactual\sfile\scontent\sprior\ssaving.\sShorten\stimeouts\sto\s2-3\nseconds\sfor\sGoogle\sand\scustom\sfavicon\sretrieval.
D 2015-05-10T19:20:49.392
F .zip.py 19302516b3566218afe789bac77f2e412b1778a6
F CREDITS 08a335d93f79748df2b2aa7dc1ea743934b1da8f
F Makefile 014fb4ee7294094d9005d1dc90a69f1da9f89a6a
F NEWS d5a50a45144045e4a7f3dbea6b4e002bea56a989
F PACKAGING 1814db3da60057eb83881ce9db147ba543c87e17
F PKG-INFO 1adf7674b8574b04fda5b923a18410a9bcf15781
F Packfile 36a5a640fb7191e2972d8929c621d43aa8c4913f
F README dcbecb80515e1cb57d022f0959f5f4f6cf84fdd2
F action.py 02cf432a5ff9e0c8db9241a707580d72a25d762f
F ahttp.py 5b9a02ed1c79e540cf792aa92b0f3ad3d24d65ea
F bin 26fdffbcd8b00f17202781a5c6db76dc49b5469e x
F bundle/kronos.py 5bb84d4fc4d55471db76ad3b15e6d794a7deb4cb
F channels/__init__.py 50c58e1601aea9ad036961bad09a7241980ca034
F channels/bookmarks.py 74d1845f3d061f70e5616322a4e40c54045e3d19
F channels/configwin.py 2e64bb2fe78b2130d593c68fac3dbdff1c1da6fe
F channels/dirble.py db262a5d06e6b2e6db89ac605cca47648ed390a9
F channels/dnd.py 129abbd2dace7269d473e2b96f3160298503ecde
F channels/exportcat.py 66f2154eb874eb5278445f86f58409188526c069
F channels/favicon.py 444cf2c952cd4146742865299bb9f6ec2f5dbbe7 w favicon.py
F channels/filtermusic.py 35c1830b55755bf4cee740c51708c2574e0c5873
F channels/global_key.py 62a1ee3f859f5527634711618951e6f65087c375
F channels/history.py 01717d6882d0ef2f42e82aae35234f6feac86079
F channels/internet_radio.py f1f9b6b827972de28a4808535faab519a468ff17
F channels/itunes.py 7f3b7c5cee5ee39c263fcfebbad5fc0199fcd89d
F channels/jamendo.py 92e5f9ec0f2838ddf6538662855832b6492167bf
F channels/links.py bf377754fc942400f80948e7d558870ff3cc00be
F channels/live365.py f2cc1bc432dadbd0185f64d1b585c7bd156662ac
F channels/modarchive.py 932f509dd8f45c4806f4026fdad2f10ef560080a
F channels/myoggradio.py 7ec1d08cee407029c390f13839405e8662f5ca44
F channels/pluginmanager2.py eafd3844f6ab83eacf5510823935c47939abbb5d
F channels/radiobrowser.py ef7c2e6649ee46af9ee3422f56f25deb80df9c90
F channels/radionomy.py b2195e3fad7ed92d77bb6704ed4eb59d603dd529
F channels/radiotray.py f195cf603e823c3addad2ccf17bae40498bb66b1
F channels/search.py a7c64150ea86a2a7bb0d774b45e80cd8107ddd62
F channels/shoutcast.py f2e0c497b65c900f9fc81555bc4a6b4d270638fc
F channels/somafm.py ff62835ca57fdb6a710e76358aa75c9ac37302c2
F channels/streamedit.py 24f4e6c91a202bf666f8607a5c9cb61480d17ad2
F channels/surfmusik.py 42aa02e15635b4a342b0a38b8f0c73411e161625
F channels/timer.py 3c5751b8b1775a9af5e9c646cbcbf000e7fd272c
F channels/tunein.py ed1a42d71db68c2ec3ab015092964371cc1f15cb
F channels/ubuntuusers.py d59a32fd629d9a99e1aad4b06ca254d423ae09ef
F channels/useragentswitcher.py 656ccfb2dd311dee4c324b8ee7242b93fac6e7eb
F channels/xiph.py 43c0a4353bae39e1cb74cf29b1820139dfbc6ac4
F channels/youtube.py 296b5551ada5452248c5ea43283308c3a05607e1
F cli.py de8c7264723db348c1df40bbb3784ce5f8a64fd7
F compat2and3.py 66a57d4e67a8afc20dfd46b9f44b97b4a7d525cd
F config.py 8242f27bc42ad54829532068a3ee7672dc3e7d1c
F contrib/compound.py ca7af6a4e840bb11e52c6e24cfe88bd0d24d7a8d
F contrib/delicast.py 78844d8df5c5a92a40b359451852d52ad4613fd8
F contrib/di.py 09e4c6e16c6ad08ac672646094bfe0fa46eabf79
F contrib/file.py a796fcaf0b0090033effebd66dc2d2d20912fd3d
F contrib/glrp.csv.gz a093cc8433208b3209de3a5cf40c71f0132f9bf4
F contrib/glrp.py 698577c08be0c4df9e8aafa7522708d7f4e73704
F contrib/icast.py 8f41776e45537c1ceeb53aac2d7d9f1bb377578c
F contrib/listenlive.py 98eef5d4603df4d535342c9bd069b81d4cbcd0d9
F contrib/magnatune.py 0577bfd522ed8c6f3debca0b9332ccbb133f8db7
F contrib/podspider.py 41ea1a8df2540079fe05ef77e6e55f106389631a
F contrib/publicradiofan.py 27f032530a61d750edc5ca2a05faaa1b89089baf
F contrib/punkcast.py f6c4524b4e50e13f12cafda09d3b6ca656e9e908
F contrib/streamripper_addgenre 51b695f41d9f9ad2aa69486923d9397fa7e0e332 x
F contrib/windowsmedia.py 001f709eb0dad0b21ce1e49cd0c2a5fe11f04696
F dev/findeeer.svgz 43c899ab932bfe0ce918374f7219ad705342681c
F dev/icon.svgz a382ce198b7ad88f5e303551e3b308db2409243f
F dev/logo.svgz ee5159aa49ca4728e2d169d33422274bd9eaa272
F gtk3.xml.gz c6569919cf7eab94bed2386c53a6d243ced078a1
F help/action_edit.page 474edb59e2046d794755191a2633a3050d5d99a1
F help/action_homepage.page 8a24a04e4df89c37350189de1ef717a18cd56871
F help/action_playing.page 8336c6e87c7372c6262c496971895d0d5d54194b
F help/action_recording.page 68b00a5e32070ca4e6b86b87d780a7051cd027f9
F help/action_saving.page 8a7c8020d688532a4221f87a8d2530958518d897
F help/channel_bookmarks.page b8f52ac3e6acae4e2dc6709e5cd5a67092f323ac
F help/channel_dirble.page a2c2f649624d4367d6b48a920d32db1442697a26
F help/channel_filtermusic.page a631ab5fb5da336df73fb2a6b535c5cd0071645d
F help/channel_icast.page eecefba447bdcd2070dad9ddcb3f3caa648a1818
F help/channel_internetradioorguk.page 7d2361e1e84c2b9710039543bba333e615ff078e
F help/channel_itunes.page cd1ba54f9c21242e624187ff0db0fc3395e9563d
F help/channel_jamendo.page c1feadbd9f38aee1249f73e3ebf6a913640e022a
F help/channel_live365.page 508fbb9aa2c9e79126d48af4e06cfbcb7aba969d
F help/channel_modarchive.page 486456070685f5bfdcb1e4b38527ce34b3a65e89
F help/channel_myoggradio.page 2b741bd0c889644ff863a2b0febddb86da4ddd61
F help/channel_radionomy.page 53cbc94f9b9cf9d3f38c4676eb6f4302a04698ce
F help/channel_shoutcast.page 0204baa354d23917289602395db1c83c8466bfc4
F help/channel_somafm.page 58b63d59c4130a352af0931ab82d419d1024cef8
F help/channel_surfmusik.page 4cb450c5448558aae9d71c3a60cf97d2a8bf3efb
F help/channel_tunein.page 930a0d5198b1cbae7a0022c479258cb4083bae56
F help/channel_ubuntuusers.page 42655fceb5655373f004131ff9012dd1a80c9c8c
F help/channel_xiph.page cff20259ece520b725ba9772731b70a613f5e921
F help/channel_youtube.page 4cb51d6eec9f331ff907fe885735c353af0235ef
F help/channels.page e29b8eaa5fbfadd2a97441800acaae3bb799f8b3
F help/cli.page d21ecbb816ad758b967c2df8b212cfa3401c4d65
F help/config_apps.page 88f4824a2c0a8a10e2abed1f948b5ea0cb7ab5e4
F help/configuration.page 2f8c9f912de6f8d2b12c8139372d0c5d7175ef1a
F help/dragndrop.page 63af538af2016a47286d36c8de71818e6a22a1e1
F help/exportcat.page c87fe2cfa86405491fd2ed51ada205027338cd8d
F help/global_key.page a92dfe7ae033e58de7856c61c8642d71054b11e4
F help/glossary.page f9acb8a091517cf2dc5c85489eeffef6ffb7e237
F help/glossary_json.page d64e2b8f4946b5b48060595b92667b82b21e266c
F help/glossary_m3u.page 4384d57735332b6f5dfa6ac983aae637c324101e
F help/glossary_pls.page cc14ff4447dc592f72a7df4aafbef088c2361f36
F help/guiseq 3190fe5d6b1cbe5f9b918bdd7a5a1d1617ca4836 x
F help/html/C.css ac93dbe244c9501d92f8108dc0419b28ae6413e8
F help/html/bookmarks.html c69a388fc3b73127797202b6861671c0b29ab30a
F help/html/channels.html 8205a3a87a8439a31cdae0aec6a52cc6dc35d458
F help/html/cli.html d3c5a19db7c1d37ea234c4e4d137b3e3c6f88865
F help/html/config_apps.html ea9013933c3f9efe6b6bf8a5edab92ac9cfd0e7d
F help/html/configuration.html 4d19e29f0534c3614e549cd60026efbe223d418f
F help/html/dirble.html eb6889438c9cf719b338c94bf425af5acac9d036
F help/html/dragndrop.html 3bc0a5d01f1e94711b9547212632809241910e47
F help/html/edit.html b8d781a7786ed2ebe571b2bc7716c6e3595dc031
F help/html/exportcat.html b528a7d076023b2fcf0cfe5d926e48dfe6959610
F help/html/extending.html bbaab3fc5ecd4863f3d13f62b4203e27dcced4dc
F help/html/filtermusic.html 903a7247eb17c509706a8a65ccb1caa2009f5611
F help/html/global_key.html 613e65d9ce6b8d68753e78715b6c9b1bd4ba2999
F help/html/glossary.html c9ba04cb6a50a629e39472b496e277ec9e0cc49b
F help/html/homepage.html 28014251ded7d9f9a373ba4375dd356abceb26da
F help/html/icast.html 87ad638d9d47abd5384064ccbfe7702679bce643
F help/html/img/channels-left.png 723c05a87aa89c2fae123f249e533837e5eec02a
F help/html/img/channels.png 6e6ce43cca8437fd272d0374d10cb854888ea06d
F help/html/img/configapps.png e2e7f2d2f23f832803eca0f2036a32517bf31057
F help/html/img/configplugins.png 2cf2f8513ea613fb539cc99d2a807ccfa2b989ad
F help/html/img/configtabs.png c2e715fa1b9cca7be466fba30a24f5565b4b9d09
F help/html/img/logo.png d57b856bc557ae47c98f7660b5d925d5ee58b967
F help/html/img/mainwindow.png 5676a39e21ac18c7d7cb74a326162865a9e1e507
F help/html/img/pluginmanager2.png 9cc291ed1ee1c3ae76f1a5589ba6a1a71aa78fd3
F help/html/img/search.png f98b7ebb79230a4837ef02cbfc1c63a5a7154171
F help/html/img/streamactions.png 4f712e868091f377b76d66c407d02700db1b051e
F help/html/img/streamedit.png 11d60576eaed4a06504fa248f9424156d269d496
F help/html/img/streams.png 06fa1b320c540a11c65833a31ee378f121b00ed8
F help/html/img/timer.png b1d272cd815b7f54b5ca4193c31164998fb48615
F help/html/index.html 8dff2fe16eb1328a1d8f2a8803330fdca0476e26
F help/html/internet_radio_org_uk.html 7f2212e65a2394646fb37af1a518aff1f7c3c837
F help/html/introduction.html 9e00082d7335df889d23b27bfc2213f816ee6ac1
F help/html/itunes.html c383232638dd2db9005ea4c0dd807b26acd27b93
F help/html/jamendo.html 874ec05299bba51b2daaf8b4a21a9e8a9ad6fcfa
F help/html/json.html 2134222888eb15872c47fef4688d3ed9a4c4b533
F help/html/live365.html 33ca6bba4db284200c08f812f5e9a4dae6778f8d
F help/html/m3u.html 49e962abe93d2e604bad5067c87a33213df58872
F help/html/modarchive.html 8cf6ce396fdd15e8971171c0f23a13d0a9878b44
F help/html/myoggradio.html 10c78ece27c1ef9e141d447d8406a3801cf9e8c5
F help/html/playing.html 6170f4333d9850fcdb29d73e713c461c0dd24a17
F help/html/pls.html 20f1f3c4d48a70279525bf5f60f7c3612d11950e
F help/html/pluginmanager2.html 8e973d6b44cdd1e21a081d8ed105421adbfe650d
F help/html/radionomy.html 95ff47f74330b3363d78614fa86a8765cc68391d
F help/html/recording.html ff6bd6ba77b2228e14805cf9fa6461f09ef12bca
F help/html/reloading.html f2c94302c329f91770b09e7372dfebbf2b202cf4
F help/html/saving.html 26b816526e1807b5378120c20a8947d8b734eaae
F help/html/search.html 452a5460a4d3b135a836622e779528acbd575c22
F help/html/shoutcast.html 751c1f6e943e06fe860867eca2862c8e3741c744
F help/html/somafm.html a39f400d93f56b27e6de3bdfff815379afe352be
F help/html/streams.html cf46a67e7103c935dd5024582b07b18a7f9664f3
F help/html/surfmusik.html 1ba04af6bc354dca8aa168430df1cfdb3b8e560a
F help/html/technical.html d7562305553eed8f36a5811f79ee042091005f3a
F help/html/timer.html 5c6a670cedf22ed5b097f740cd399db3d4b882df
F help/html/tunein.html 6a61a6a5f2cd4b1293f258a65b495c9a2b0b5494
F help/html/ubuntuusersm.html 9e1b18d9e5e271fc493e84ee3ed3af0c70612828
F help/html/xiph.html 9154159e18d42647a297e126de71ebaef96d9b20
F help/html/yelp-note-bug.png 81ab32a85c103b04de295a0dacf3c820d8d120a9
F help/html/yelp-note-tip.png d74d224d406b924aa2473782ce6cda51d2a19881
F help/html/yelp-note-warning.png d6a48bb87d9d54ebb4bc372f08beee3746c8caaa
F help/html/yelp-note.png a67020c1dc96e8fdc33659075f6be7c8d6ad0571
F help/html/youtube.html f9f2e6e0de628997b2d0920ae969dc398c9a50d9
F help/img/categories.png c36f7cbd6d53b8c4073dd9564a069709b567ea9e
F help/img/channels-left.png 723c05a87aa89c2fae123f249e533837e5eec02a
F help/img/channels.png 6e6ce43cca8437fd272d0374d10cb854888ea06d
F help/img/configapps.png e2e7f2d2f23f832803eca0f2036a32517bf31057
F help/img/configplugins.png 2cf2f8513ea613fb539cc99d2a807ccfa2b989ad
F help/img/configtabs.png c2e715fa1b9cca7be466fba30a24f5565b4b9d09
F help/img/logo.png d57b856bc557ae47c98f7660b5d925d5ee58b967
F help/img/pluginmanager2.png 9cc291ed1ee1c3ae76f1a5589ba6a1a71aa78fd3
F help/img/search.png f98b7ebb79230a4837ef02cbfc1c63a5a7154171
F help/img/streamactions.png 4f712e868091f377b76d66c407d02700db1b051e
F help/img/streamedit.png 11d60576eaed4a06504fa248f9424156d269d496
F help/img/streams.png 06fa1b320c540a11c65833a31ee378f121b00ed8
F help/img/timer.png b1d272cd815b7f54b5ca4193c31164998fb48615
F help/index.page 00b261c4fe780faba173a0981448ff02cc1a1d95
F help/introduction.page 911838906ff5af28ab45c661d61815f798fdca82
F help/pluginmanager2.page a90ffe8159b575289eb7c89e40582e4fe77a741c
F help/reloading.page ed3b674648f41fdf5639a0df200be7162093ac85
F help/search.page 48c7a270bc7743e5d8e85cf7f2fdac11c3d5097b
F help/streams.page f9a2851bcdf98f1fc45c5950ba20e2c6f7b41ef6
F help/streamtuner2.1 18941ca643becd5b7f0835a0f419a6f163cb02c9
F help/technical.page f416212abdb2c2c3e773f9d469e77c7767855804
F help/timer.page 0ed0debb665f3975226b6540cb4cd8b81413197a
F icon.png bf09ed125a0b6368360f30c40b8f61ceac666300
F logo.py 764b7e427fb2fe56eb375524f856c37ee3605f1f
F pluginconf.py a5813116de359244b6e94ff444741d3468576fa8
F pq.py 9ad9a3d4262884ace4d6a4b40f389a8a45e79ae6
F releases.json de83045cb941004aa82d106ac09053dd3bd09098
F st2.py 35aa375d2a29371d1a7628ce9ac2118f048ab28f x
F streamtuner2.desktop f25e24cc48fc62fd9089d673058b3e33a9fa4782
F streamtuner2.png 3bae5af93204f73db177b2bf1b545a82915f5378
F uikit.py 9362b926ba6ef81a6c8ec9cf95bf14ab402bb435
P a6b4b00c41eb891404d179231fdb3bf039073668
R 91d6e4c2469176649b03da3ed7798215
U mario
Z 16c7608fc41eb50e4da42e566a036745